Steema Issues Database

Note: This database is for bugs and wishes only. For technical support help, if you are a customer please visit our online forums;
otherwise you can use StackOverflow.
Before using this bug-tracker we recommend a look at this document, Steema Bug Fixing Policy.



Bug 617 - Incorrect fix for bug 604
Summary: Incorrect fix for bug 604
Status: IN_PROGRESS
Alias: None
Product: VCL TeeChart
Classification: Unclassified
Component: Axis (show other bugs)
Version: 140220
Hardware: PC Windows
: --- critical
Target Milestone: ---
Assignee: Steema Issue Manager
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-04 04:37 EST by trubetskov
Modified: 2014-03-06 05:49 EST (History)
2 users (show)

See Also:
Chart Series: ---
Delphi / C++ Builder RAD IDE Version:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description trubetskov 2014-03-04 04:37:21 EST 
I am sorry to say, but the proposed fix for the bug 604 reported by me earlier is not correct.

Proposed:

    if Assigned(ParentChart.FOnGetAxisLabel) then
       tmpHeight:=Horizontal  //  Berneda bug 604 fix
    else
       tmpHeight:=( Horizontal and ((tmpAngle=0) or (tmpAngle=180))) or
                  ( (not Horizontal) and ((tmpAngle=90) or (tmpAngle=270)));

=> as the result the horizontal size for vertical axes titles (angle 90 deg) is equal to the length of the text! This is weird looking.
Comment 1 david berneda 2014-03-06 05:23:12 EST 
Affected bug is 603, not 604.
Comment 2 david berneda 2014-03-06 05:49:53 EST 
Sorry again. I think the correct code is just commenting the wrong code.

I've tested vertical and horizontal titles, with both 0 and 90 angle rotation and it looks correct.



{  // Commented:
    if Assigned(ParentChart.FOnGetAxisLabel) then
       tmpHeight:=Horizontal
    else
}


       tmpHeight:=( Horizontal and ((tmpAngle=0) or (tmpAngle=180))) or
                  ( (not Horizontal) and ((tmpAngle=90) or (tmpAngle=270)));